search

TheThirdOne / rars

RARS -- RISC-V Assembler and Runtime Simulator
Other
1.15k stars 217 forks source link

Help for "digital lab sim" could be improved #142

Open hoskam-l opened 2 years ago

hoskam-l commented 2 years ago

The line "Each bit of these two bytes are connected to segments (bit 0 for a segment, 1 for b segment and 7 for point " Is incomplete and at the very least 'unclear'.

I suggest revising the line to state "Each bit of these two bytes are connected to segments: bit 0 for segment 'a', bit 1 for segment 'b' and bit 7 for a point(decimal)."

We read, bit 1 for a segment, and while we continue to read we are asking ourselves, "okay, what segment?" and we start to miss other key details. I think my suggested replacement might not be the best. But it does clear up some confusion and state explicitly which segment bit 0 is connected.

This is probably the least of anyone who is working on this projects worries. I just thought I could share...

TheThirdOne commented 2 years ago

The revised help text would be superior, and it would also be nice to also have a diagram like diagram from wikipedia