TheTimeWalker / wallpanel-android

WallPanel is an Android application for Web Based Dashboards and Home Automation Platforms
https://wallpanel.xyz
Apache License 2.0
454 stars 45 forks source link

Fix CPU being turned off. #48

Open FredericMa opened 2 years ago

FredericMa commented 2 years ago

This PR should fix the issue seen in #39. The wakelock was only kept for 3 seconds so when the screen was turned off, the CPU was also turned off. In order to fix this, a few things needed to happen:

Please review these changes and test them yourself since I'm not an Android dev so maybe things should be done differently. This PR might also impact battery life since the CPU will never be turned off while WallPanel is running.

Maybe you can create a Pre-release for this one so other people can also test it first?

netlify[bot] commented 2 years ago

Deploy Preview for wallpanel canceled.

Name Link
Latest commit e47ab5dccf0b65bc071860125723067a4fac6138
Latest deploy log https://app.netlify.com/sites/wallpanel/deploys/636819e3c9d1ab000a4b0269
FredericMa commented 2 years ago

@TheTimeWalker Any chance you can find some time to review the changes in this PR?

FredericMa commented 1 year ago

It looks like this functionality breaks when brightness control permissions are granted. I'll check why this happens.

amasolov commented 1 year ago

@TheTimeWalker Would be great to have it reviewed and merged!

TheTimeWalker commented 1 year ago

@amasolov It is still regarded as Draft so I've been holding off of reviewing

FredericMa commented 1 year ago

I'll try to find some time in the coming days or weeks to take a look at the remaining issues with this PR.