Disable caching by default (make opt-in)

TheTransitClock / transitime

TheTransitClock real-time transit information system

GNU General Public License v3.0

78 stars 30 forks source link

Disable caching by default (make opt-in) #137

Open nselikoff opened 5 years ago

nselikoff commented 5 years ago

Perhaps caching should be disabled by default and opt-in, since there are multiple considerations to which caches should be enabled and how they should be configured, depending on the nature of the service.

Right now with default config, transitclock.cache.daysPopulateHistoricalCache is set to 4, and I'm seeing the StopArrivalDepartureCache, TripDataHistoryCache, FrequencyBasedHistoricalAverageCache and ScheduleBasedHistoricalAverageCache populated on startup.

scrudden commented 5 years ago

Hi Nathan,

Yes, these should be opt-in. I will change the defaults.

Cheers,

Sean.

nselikoff commented 5 years ago

@scrudden I added a config param to disable the historical caches in the branch I'm working on - feel free to cherry pick it.

scrudden commented 5 years ago

@nselikoff Thanks.