search

TheTransitClock / transitime

TheTransitClock real-time transit information system
GNU General Public License v3.0
78 stars 29 forks source link

Problems in the shape of the routes after importig GTFS #241

Open vsperez opened 3 years ago

vsperez commented 3 years ago

Expected functionality The routes should be the same as the GTFS file.

Describe the bug In some case, the construction of the shape results with unexpected segment from the polyline to the busstop.

To Reproduce Import specific GTFS.

vsperez commented 3 years ago

This ocurres while the algorithm is searching the location on the busstop along the shape. When the best match is not found or the best match skips the correct location.

The fixing, in all the cases, is using the ShapeDistanceTraveled of GTFS. If it is not provided, the parameter maxDistanceBetweenStops should be carefully selected in order to avoid the cause.

wkulesza commented 7 months ago

It would help if you could provide example valeus for maxDistanceBetweenStops and maxTravelTimeSegmentLength. I currently have 20000.0 and 100

vsperez commented 7 months ago

Hi Wojciech,

Generally speaking maxDistanceBetweenStops depends on the topology of the route. The algorithm will search the next stop until maxDistanceBetweenStops. If next stop is farther that that, it might be an issue. So 20 km it is quiet a lot, but if the trip is between towns without too many stops you might consider even greater values. 

On the other hand, according to the parameter documentation:

maxTravelTimeSegmentLength: "For determining how many travel time  segments should have between a pair of stops. Default is 200.0m, which means that many stop stopPaths will have only a single travel time segment between stops.”  I would recommend about 50% or more of maxDistanceBetweenStops, considering that maxDistanceBetweenStops is set according to the topology.

Best regards Vicente

On 28-11-2023, at 08:13, Wojciech Kulesza @.***> wrote:

It would help if you could provide example valeus for maxDistanceBetweenStops and maxTravelTimeSegmentLength. I currently have 20000.0 and 100

— Reply to this email directly, view it on GitHub https://github.com/TheTransitClock/transitime/issues/241#issuecomment-1829610555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUAAGDONZUXFZMZFQ3SO6DYGXBO3AVCNFSM467HNU42U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBSHE3DCMBVGU2Q. You are receiving this because you authored the thread.