search

TheTrueIndolent / voodoo-casting-bar

Enchant your default casting bar!
https://www.curseforge.com/wow/addons/voodoo-casting-bar
Creative Commons Zero v1.0 Universal
1 stars 1 forks source link

LagBar not working on every spell + Lag Bar not properly updating. #4

Open Toonic opened 3 days ago

Toonic commented 3 days ago

I was messing around with it on my Warlock and I noticed that not every spell is working as expected. When I cast Incinerate, or Immolate, neither of the spells trigger the lag bar code.

To test this I modified the code in the PlayerCastLagBar function, and added a simple print("Hello") inside of the if playerSpell and VCBrPlayer["LagBar"] == "Show" then. And noticed that no debug message was printed on Incinerate or Immolate. However, casting any other spell would show the lag bar and the print.

Toonic commented 3 days ago

Update: You'll want to change IsPlayerSpell to IsSpellKnownOrOverridesKnown the issue in my case is specifically due to the spell being overriden to the "Green Fire" Variant of a Warlock.

Toonic commented 3 days ago

Additional bug as well: The lag bar value isn't updating properly. Specifically, if you cast one spell, and queue up a second spell (Or even just spam the spell cast button during the cast.) the bars latency will never change.

I'm unsure of the root cause of this currently. But its something that I've noticed.

EDIT: This seems to be normal behavior. I've tested a few different addons. (Quartz, Weakauras, etc.) And all have the same behavior.

TheTrueIndolent commented 1 day ago

The funny thing is if your print(lagTotal) you will see that the number is right, but the bar doesn't change! And another funny think is if you run the /eventtrace in the game you will notice that it tracks your lag in some events like the event "UNIT_SPELLCAST_START" in milliseconds but the only way I could take the number is the way I use in the add on.