1.19 Most spawn rewards broken

[tatoyoda600]

Minecraft Version:

1.19 1.19.1 1.19.2 (Did most of the testing on a server because I didn't want to be restarting MC every 5 seconds. Game did crash in singleplayer on 1.19.2 though, prompting the more in depth test. Also had the lucky block mod installed, but nothing else)

Forge Version:

1.19-41.1.0 1.19.1-42.0.9 1.19.2-43.1.1

ChanceCubes Version:

1.19-5.0.2.467

Reward(s) Affected:

chancecubes:spawn_glenn chancecubes:xp_crystal chancecubes:spawn_cluckington chancecubes:actual_invisible_ghast chancecubes:spawn_amanda_panda chancecubes:item_chest chancecubes:cake chancecubes:rain chancecubes:ender_crystal_timer chancecubes:book_of_memes chancecubes:dark_o_the_wise chancecubes:spawn_jerry chancecubes:quidditch chancecubes:fire_aspect_fire

chancecubes:question chancecubes:herobrine

The Issue:

On 1.19 the mentioned rewards do absolutely nothing or only part of the intended behaviour. The ones that do something: chancecubes:item_chest (No chest, items are thrown but disappear on landing) chancecubes:cake (Only the text shows up) chancecubes:ender_crystal_timer (Nothing shows up, then random explosion)

chancecubes:question (It might actually work fine, bue to the text showing up above the hotbar instead of the chat, it is then immediately being replaced by the countdown, so there's no way to know the question) chancecubes:herobrine (This one does work fine as far as I can tell, but due to the text showing up above the hotbar, the chat messages give no impression of actual chat messages)

On 1.19.1 & 1.19.2 the mentioned rewards just crash the game immediately if they're chosen.

Also, all the ones that look like the blocks should fall from the sky just have the blocks show up out of nowhere on the ground, no falling.

I've seen some other issues on here about how 1.19.2 doesn't work currently, so I assume that's not much of a surprise, but the ones that crash 1.19.2 seem to be the same ones that do nothing in 1.19, so maybe they're related.

As an extra note, the rewards "chancecubes:spawn_amanda_panda" & "chancecubes:dark_o_the_wise" are not listed in the Github wiki with the list of rewards, and despite basically all of the rewards that don't function being ones that summon, "chancecubes:boss_ravager" & "chancecubes:surrounded", both of which summon stuff, work just fine, even had custom AI and attacks for the ravager and the armor stand with my head on it was riding it just fine as well, killing it also destroyed the arena with no issues.

Origin:

https://www.curseforge.com/minecraft/mc-mods/chance-cubes

Logs:

On 1.19 it doesn't crash and works just fine other than the rewards not doing anything, so the log is just a standard server log with a ton of "[Server thread/INFO] [chancecubes/]: Triggered the reward with the name of: chancecubes:............"

On 1.19.1 it does crash, and gives this error when it does (Different reward name depending on which one is the one that is picked) [03Sep2022 15:44:43.332] [Server thread/INFO] [chancecubes/]: Triggered the reward with the name of: chancecubes:fire_aspect_fire [03Sep2022 15:44:43.333] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception java.lang.NoSuchMethodError: 'int net.minecraft.commands.Commands.m82117(net.minecraft.commands.CommandSourceStack, java.lang.String)'

On 1.19.2 it also crashes, and gives this error (Different reward name depending on which one is the one that is picked) [03Sep2022 15:36:16.629] [Server thread/INFO] [chancecubes/]: Triggered the reward with the name of: chancecubes:book_of_memes [03Sep2022 15:36:16.630] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception java.lang.NoSuchMethodError: 'int net.minecraft.commands.Commands.m82117(net.minecraft.commands.CommandSourceStack, java.lang.String)'

[TheTurkeyDev]

Thanks for doing some test. I haven't been fully able to test all the rewards and features (hence the Beta tag), but hopefully I will be able to find the time to test them. The reward wikis are slowly being phased out for this https://site.theturkey.dev/chancecubes/rewardstatus where I can keep greater detail on the rewards and their working status, but again finding time to completely move everything over is hard. I appreciate the help though!

[freevortex]

I went ahead and tested all of the rewards listed on https://site.theturkey.dev/chancecubes/rewardstatus on 1.19.2 (Forge 43.1.3). Tested using the reward selector pendant and a clean-ish loadout with only the following:

• ChanceCubes-1.19-5.0.2.467
• Controlling-forge-1.19.2-10.0+6
• MouseTweaks-forge-mc1.19-2.23
• OptiFine_1.19.2_HD_U_H9

As tatoyoda600 noted, all (or almost all) of the rewards that involve text that was previously displayed in the chat is now showing that text above the hotbar, and it disappears too fast to read. This is true across the board for "working" and broken rewards.

Rewards that are causing CTD:

• chancecubes:actual_invisible_ghast
• chancecubes:bad_omen [the initial building builds just fine, but then a CTD occurs; log snippet attached as badomen.txt ]
• chancecubes:bees
• chancecubes:blindness_fight [is this an isocahedron one? It said 'no such reward for this cube' for both regular and giant, then CTD when I tested it on an isocahedron.]
• chancecubes:book_of_memes
• chancecubes:cave_spider_web [CTD, but when you load back in, you're surrounded by webs]
• chancecubes:coal_to_diamonds [coal blocks appear, then crash happens]
• chancecubes:cookie_monster
• chancecubes:cuteness ["cuteness overload!" appears followed by CTD]
• chancecubes:dark_o_the_wise
• chancecubes:did_you_know
• chancecubes:diy_pie ["do it yourself pumpkin pie!" appears followed by CTD. Upon relog, a pumpkin is there]
• chancecubes:fire_aspect_fire
• chancecubes:fire_fox
• chancecubes:firework_show [GCC]
• chancecubes:fireworks
• chancecubes:giant_chance_cube
• chancecubes:help_me [cage spawns, then CTD]
• chancecubes:herobrine [text appears; 'herobrine joined the game', then herobrine says 'may the other world have mercy on your soul', then CTD. None of this happens within the chat box; it's all just text above the hotbar.]
• chancecubes:invisible_creeper
• chancecubes:invisible_ghasts
• chancecubes:invisible_vexes
• chancecubes:invizible_silverfish [note- is this supposed to be spelled this way]
• chancecubes:knockback_zombie
• chancecubes:nether_jelly_fish
• chancecubes:one_man_army [zombie piglin spawned and then CTD]
• chancecubes:pig_of_destiny
• chancecubes:potion-works
• chancecubes:quidditch ["quidditch, anyone?" appears, followed by CTD]
• chancecubes:rain
• chancecubes:remove_useful_stuff [isocahedron]
• chancecubes:sail_away [upon reload, the block under the cube was replaced with a water source block.]
• chancecubes:silvermite_stacks
• chancecubes:skeleton_bats
• chancecubes:slime_man
• chancecubes:spawn_amanda_panda
• chancecubes:spawn_cluckington
• chancecubes:spawn_dr_trayaurus
• chancecubes:spawn_glenn
• chancecubes:spawn_jerry
• chancecubes:spawn_pickles
• chancecubes:spongebob_squarepants
• chancecubes:take_this [brick tower spawned before CTD]
• chancecubes:tnt_bats
• chancecubes:tnt_cat
• chancecubes:tnt_diamond [diamond blocks appear, then CTD]
• chancecubes:wither [named wither spawns, text asking if you feel lucky appears, then CTD. Wither is still there on relog]
• chancecubes:xp_crystal

Rewards that are partially working:

• chancecubes:jar_guess [bats and glass appear, but does not ask for a guess and entering a guess doesn't do anything. Does tell you number of bats after the countdown completes.]
• chancecubes:5_prongs [isocahedron isn't quite lined up with the middle pillar, but otherwise seems to be working]
• chancecubes:boss_demonic_blaze [everything spawns in fine, but the BOSS FIGHT text is messed up]
• chancecubes:boss_evil_witch [BOSS FIGHT text messed up]
• chancecubes:boss_mimic [BOSS FIGHT text messed up]
• chancecubes:boss_ravager [BOSS FIGHT text messed up]
• chancecubes:chat_message [text disappears too fast to read]
• chancecubes:chunk_flip [GCC; seems to just kind of delete the top half of the chunk]
• chancecubes:cursed_head [you get the cursed head, but the text shows up too fast to read. Should the text be in the chatbox instead?]
• chancecubes:ender_crystal_timer [I only put this one here because of the reward name. If there is supposed to be a timer, it's broken. End crystal and base appear and immediately explode.]
• chancecubes:explosion [explosion particles appear but nothing else happens]
• chancecubes:heads_or_tails [asks "heads or tails" but you have no way to answer; typing in chat does nothing, so it eventually just says "you must be real fun at parties"]
• chancecubes:math [question appears and disappears too fast to see; timing is off; no way to input answer]
• chancecubes:question ["you have 20 seconds to answer!" pops up + a timer, but no question and no way to answer]
• chancecubes:village [GCC; roads are spawning as air blocks]

Rewards that seem to be working as normal:

• chancecubes:anti_slab
• chancecubes:anvil_rain
• chancecubes:armor_stand_armor
• chancecubes:arrow_spray
• chancecubes:arrow_trap
• chancecubes:beacon_arena [GCC]
• chancecubes:beacon_build [when the blocks are falling, they are sand; is that intended?]
• chancecubes:bedrock
• chancecubes:biodome
• chancecubes:block_thrower [GCC]
• chancecubes:bone_cat
• chancecubes:bookshelves
• chancecubes:cake
• chancecubes:carpet
• chancecubes:cats_and_dogs
• chancecubes:chance_cube_cube
• chancecubes:charged_creeper
• chancecubes:chuck_reverse [GCC]
• chancecubes:chunk_flip [GCC]
• chancecubes:clear_inventory
• chancecubes:connect_4
• chancecubes:cookie-splosion
• chancecubes:countdown [timing might be a little off?]
• chancecubes:cube_rename
• chancecubes:d-rude_sandstorm
• chancecubes:diamond_block
• chancecubes:dig_build [countdown appears, at the end there is an explosion noise]
• chancecubes:disco
• chancecubes:divine_boots
• chancecubes:divine_chestplate
• chancecubes:divine_helmet
• chancecubes:divine_leggings
• chancecubes:divine_sword
• chancecubes:double_rainbow
• chancecubes:enchanting
• chancecubes:exp
• chancecubes:exp_shower
• chancecubes:explorer
• chancecubes:fake_tnt
• chancecubes:farmer
• chancecubes:fighter
• chancecubes:finding_marlin
• chancecubes:finding_nemo
• chancecubes:fish_dog
• chancecubes:floor_is_lava [GCC]
• chancecubes:fluid_sphere [GCC]
• chancecubes:giga_breaker
• chancecubes:guardians
• chancecubes:half_fishing_rod
• chancecubes:half_heart
• chancecubes:hand_enchant
• chancecubes:have_another
• chancecubes:hearts [is all this one does is spawn two heart particles?]
• chancecubes:horde
• chancecubes:hot_tub
• chancecubes:ice_cold
• chancecubes:icosahedron
• chancecubes:inventory_bomb
• chancecubes:item_chest
• chancecubes:item_of_destiny
• chancecubes:item_rename
• chancecubes:juke_box
• chancecubes:lava_ring
• chancecubes:lingering_potions_ring
• chancecubes:loot_box
• chancecubes:magic_feet
• chancecubes:matching
• chancecubes:maze
• chancecubes:mitas [because I can't help myself; I think this should be spelled 'midas']
• chancecubes:mixed_fluid_sphere [GCC]
• chancecubes:mob_tower
• chancecubes:monty_hall
• chancecubes:nether_star
• chancecubes:no
• chancecubes:no_exp
• chancecubes:notch
• chancecubes:nuke
• chancecubes:one_is_lucky [I didn't break the blocks that appeared to test their luck, but they did spawn]
• chancecubes:one_shot
• chancecubes:ore_pillars [GCC; note: 5 pillars spawned]
• chancecubes:ore_sphere [GCC]
• chancecubes:ores_galore
• chancecubes:path_to_succeed
• chancecubes:poison
• chancecubes:pssst
• chancecubes:raining_potions
• chancecubes:rancher
• chancecubes:random_explosion
• chancecubes:random_status_effect [note: says "selecting random status effect to apply", followed by "for 4 seconds!" I assume it should say the status there, but it does not.]
• chancecubes:random_teleport
• chancecubes:redstone_diamond
• chancecubes:roosevelts_stick
• chancecubes:rotten_food
• chancecubes:saplings
• chancecubes:saw_nothing_diamond
• chancecubes:sethbling_reward
• chancecubes:silverfish_surround
• chancecubes:sky_block
• chancecubes:smite
• chancecubes:sphere_snake
• chancecubes:squid_horde
• chancecubes:string
• chancecubes:surrounded
• chancecubes:surrounded_creeper
• chancecubes:table_flip
• chancecubes:throwables [GCC]
• chancecubes:thrown_in_air
• chancecubes:tic_tac_toe
• chancecubes:tnt_structure
• chancecubes:tnt_throw [GCC]
• chancecubes:torches_to_creepers
• chancecubes:trampoline
• chancecubes:traveller [assume working; coordinates appeared but they were not in chat box so didn't save]
• chancecubes:troll_hole
• chancecubes:troll_tnt
• chancecubes:wait_for_it
• chancecubes:want_to_build_a_snowman
• chancecubes:watch_world_burn
• chancecubes:wheel_spin
• chancecubes:witch
• chancecubes:wither_status_effect
• chancecubes:wolves_to_creepers
• chancecubes:woodland_mansion [GCC]
• chancecubes:wool
• chancecubes:world_infection [GCC]

I turned all crash-inducing rewards, as well as the question-type partially-working rewards (and chancecubes:5_prongs since it spawns an isocahedron which should be unobtainable), to FALSE in this config (presented here as a .txt - just copy the contents into your global_rewards.json and you should be good to go) so that others can easily turn off the broken rewards until you come out with a fix. global_rewards.txt

Thanks for the mod; I hope this playtesting helps get 1.19.2 working :)

[PurpleHel]

I would also suggest setting dig_build to false, cos the text doesn't display long enough to see if you're supposed to go up or down and how far.

[PurpleHel]

Which reward is the _jeb sheep? Game crashed when I tried to break the isocahedron. Is it disco?

[TheTurkeyDev]

New build is finally out. should hopefully fix most of these rewards!