search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

page won't load with adblocker on #151

Open MrBryan opened 8 years ago

MrBryan commented 8 years ago

Not sure if this is a legit bug per se but when I load the gh page with my adblock software (adblock pro) the screen goes dark with a semi-opaque overlay as though the popup modal thing is gong to show up but it just stops there and you can't click it away . Just to note for later

MrBryan commented 8 years ago

only on first load so yes it's the container for popup likely:

maybe could add a failsafe somehow

alexgreen commented 8 years ago

I'm having the same problem with Chrome browser on both my ipad and my android phone, although I don't think I have any kind of ad-blockers enabled. The screen is greyed out by an overlay rendering the page nonfuncitonal, but no pop-up appears. The only way to access the content is to refresh the browser page.

phillipadsmith commented 8 years ago

I'm having the same problem with Chrome browser on both my ipad and my android phone, although I don't think I have any kind of ad-blockers enabled. The screen is greyed out by an overlay rendering the page nonfuncitonal, but no pop-up appears. The only way to access the content is to refresh the browser page.

Crap.

Assigning myself. Will look at this weekend.

MrBryan commented 8 years ago

Going to disable for now and schedule for post-launch

MrBryan commented 8 years ago

Did anything change with this? I have it disabled at the moment, is it OK that it will be solved after launch or is it ready?

phillipadsmith commented 8 years ago

Did anything change with this? I have it disabled at the moment, is it OK that it will be solved after launch or is it ready?

Nothing has changed. Feel free to disable for now and we'll loop back to it after launch.