search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Menu label position on small views #266

Closed phillipadsmith closed 8 years ago

phillipadsmith commented 8 years ago

@alexgreen I don't remember the menu being in this position before:

iphone_5s_-_iphone_5s___ios_9_3__13e230_

This is on the GitHub pages site, as well as preview.

Is that the way it's always been?

alexgreen commented 8 years ago

I've never seen this. here's how it looks in OSX chrome:

screen shot 2016-07-11 at 5 30 36 pm

phillipadsmith commented 8 years ago

I've never seen this. here's how it looks in OSX chrome:

Perhaps, but not how it looks on iOS / mobile Safari.

phillipadsmith commented 8 years ago

iPhone 5 viewport size.

alexgreen commented 8 years ago

It's fine on android nexus

alexgreen commented 8 years ago

I'll have a look. However, I have not done any work on the nav, so I'll be going in blind.

phillipadsmith commented 8 years ago

I'll have a look. However, I have not done any work on the nav, so I'll be going in blind.

Appreciated.

(Where's the blind emojii!?)

alexgreen commented 8 years ago

I think the problem is that the button is wider than the bootstrap column that contains it:

screen shot 2016-07-12 at 1 22 59 am

alexgreen commented 8 years ago

This should fix it: 9fd5360e8d071e37b8b843ad8bbc9f24d2c850d6

phillipadsmith commented 8 years ago

This should fix it

👍

alexgreen commented 8 years ago

...so I guess this issue should still be open, pending implementation in bric?

MrBryan commented 8 years ago

already implemented, the global nav is in git in bric