TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Interim menu problems #269

Closed phillipadsmith closed 8 years ago

phillipadsmith commented 8 years ago

So, the interim menu is wonky if you click more, then click search:

the_tyee___news__culture__solutions_

Not a launch-blocking problem, but should get fixed.

alexgreen commented 8 years ago

I would say this is launch blocking. We should not launch like this. There's odd background colours throughout the nav:

screen shot 2016-07-11 at 10 31 59 pm

screen shot 2016-07-11 at 10 32 19 pm

phillipadsmith commented 8 years ago

Yes, indeed, I discussed earlier with @MrBryan on Skype (see backlog).

MrBryan commented 8 years ago

that pictured above is the nav on the new site not the interim but in any case both are now fixed

alexgreen commented 8 years ago

that pictured above is the nav on the new site not the interim

I'm not following. Are there 2 new sites we're currently working on? Just to be clear: I have no awareness of this. As far as I'm concerned the develop branch, the gh-pages branch and http://preview.thetyee.ca/ all represent the changes to thetyee.ca that we're trying to launch this week and they should all exhibit exactly the same front end qualities. So I have no idea how I could possibly have been looking at the wrong site when I took that screenshot. Is there another dev site somewhere?

alexgreen commented 8 years ago

... unless you're saying that the nav block on the tyee homepage will be generated from a different code base than the nav block on the article pages (i.e. there would be 2 duplicate code bases for the nav block). ?

MrBryan commented 8 years ago

yes we have a hacked together interim nav that duplicates the appearance of the new design for non-article pages, if you look at the home page http://preview.thetyee.ca

MrBryan commented 8 years ago

(but don't spend any energy on that - phillip was tagging it here just so we'd remember to do that before launch)

alexgreen commented 8 years ago

...there's still some critical work to do on that interim nav. #277