search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Broken functionality: overflow: hidden on comments is hiding the reply options and more #298

Closed phillipadsmith closed 8 years ago

phillipadsmith commented 8 years ago
sunny_ways_or_gloomy_days__checking_in_on_liberal_promises___the_tyee
phillipadsmith commented 8 years ago

Respond to Andrew Henderson when resolved.

phillipadsmith commented 8 years ago

To be deployed, @MrBryan, at your next opportunity. Thanks.

MrBryan commented 8 years ago

I cherry picked it on preview and it still doesn't seem to expand far enough down still

image

MrBryan commented 8 years ago

i guess that's less of a big deal though that's only if you try to comment on the last comment

MrBryan commented 8 years ago

ooh that's smart -- if you reference the issue in the commit instead of the other way around it shows up on here when I cherry pick it

MrBryan commented 8 years ago

p.s alex and i were talking and we were thinking we would keep issues open until they are on production and assign to me if they are awaiting deployment

phillipadsmith commented 8 years ago

Can you mark this as closed? :-)

On Jul 14, 2016, at 1:14 PM, MrBryan notifications@github.com wrote:

p.s alex and i were talking and we were thinking we would keep issues open until they are on production and assign to me if they are awaiting deployment

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/TheTyee/design-article.thetyee.ca/issues/298#issuecomment-232778909, or mute the thread https://github.com/notifications/unsubscribe/AACFUGmZvIXJuAyeb93mU_aRcf3veiHGks5qVpi6gaJpZM4JMwET.

MrBryan commented 8 years ago

It's already closed - get some sleep !