search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

Implement a comment count functionality on article page #337

Closed phillipadsmith closed 8 years ago

phillipadsmith commented 8 years ago

https://basecamp.com/1929296/projects/10634215/todos/266293077

First pass:

perfect_storm _engulfing_canada s_economy_perfectly_predictable___the_tyee

cc @robynleighsmith

phillipadsmith commented 8 years ago

Small screen mobile:

perfect_storm _engulfing_canada s_economy_perfectly_predictable___the_tyee
robynleighsmith commented 8 years ago

That looks great to me, Phillip.

phillipadsmith commented 8 years ago

New mobile treatment to avoid line breaks:

perfect_storm _engulfing_canada s_economy_perfectly_predictable___the_tyee
phillipadsmith commented 8 years ago

Ready for testing and deployment: https://github.com/TheTyee/design-article.thetyee.ca/tree/feature/comment-count

Merged into 'develop' also.

phillipadsmith commented 8 years ago

There is something still to figure out, however:

The way that Disqus' JS determines where to put the comment count data is by looking for an anchor tag with a hash fragment of '#disqus_thread' ...

But, for some reason, that hash fragment is not firing as it should when the link is clicked. I'm wondering if it has something to do with the JS that jumps the user down to the comments, and opens them up, when the comment bubble is clicked? Guessing so... these two might need to be reconciled to work together.

Over to you, @MrBryan. :-)

MrBryan commented 8 years ago

It's mainly because it was looking for #comments rather than #disqus_thread but the comments text and icon were different so targeted them both now

f3ce68d

robynleighsmith commented 8 years ago

@MrBryan @phillipadsmith Looks good, guys!