Closed phillipadsmith closed 7 years ago
OK I removed it.
I'll try to make sure any of my changes are backported to develop repo when I test the changes on preview.thetyee.ca/bc-bricmod
removed the inline html that is, and tested it preview+live and it works
Hey @MrBryan,
I've moved the e-mail subscription form JS into
article_custom.js
and I've updated the include that contains the forms to match the HTML on the site.I'd like to do another update so that code automatically uses the correct version of the webhook app, depending on context -- local, preview, or live -- but I'm going to leave that for the moment.
Please see this branch for the changes: https://github.com/TheTyee/design-article.thetyee.ca/commits/feature/fix-email-subscription-form
So, the changes would be:
Let me know if you have any questions,
Phillip.
P.S. Let's make a note to loop back to a discussion/documentation of how the whole site is wired together now. I was stumped for about an hour on getting these changes made because the HTML structure in the GitHub repo for this section does not match what's live on the site, which makes doing work in the usual workflow quite difficult. Probably an artifact of our launch-related deadlines and last-minute juggling ... but going forward it's important that everything stay in sync as closely as possible, or at least get documented as not being in sync (in the GitHub code), because otherwise figuring that out is going to cost someone some time down the road.