TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

latest-stories object -- reconcile differences between repo and the live site #347

Closed alexgreen closed 8 years ago

alexgreen commented 8 years ago

live site and repo currently have different html for this object

MrBryan commented 8 years ago

I did a diff and I see some comments are removed but what are you noticing that has a consequence?

alexgreen commented 8 years ago

Can't remember exactly what I meant but there's a couple differences I see right off.

In the live version each media item is wrapped in a <a> (header version only?) but not in the repo (here the links are within each div).

LIVE: screen shot 2016-09-13 at 4 56 22 pm

REPO: screen shot 2016-09-13 at 4 57 13 pm

Oddly there's also differences in the CSS.

LIVE:

#latest_bottom_wrap {
    border-bottom: 1px #929292 solid;
    padding: 10px 0;
    margin: 40px 0;
}

REPO:

#latest_bottom_wrap {
    border-top: 1px #929292 solid;
    border-bottom: 1px #929292 solid;
    padding: 10px 0;
    margin: 40px 0;
}

Not sure if there's other differences.

MrBryan commented 8 years ago

Got the HTML differences sorted here

72724c6

and css here (removed top border from develop -- looks better sans)

7dc28a436f9d0058e7753b2e94af6a7ffa8a8794