Words floating out of column in Firefox

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design

http://thetyee.github.io/design-article.thetyee.ca/

Creative Commons Zero v1.0 Universal

3 stars 0 forks source link

Words floating out of column in Firefox #349

Closed MrBryan closed 8 years ago

MrBryan commented 8 years ago

That happens at larger widths on stories in Firefox

This screenshot was from http://www.thetyee.ca/Culture/2016/09/07/Killer-Whale-Who-Changed-World/

MrBryan commented 8 years ago

Any suggestions, Alex?

alexgreen commented 8 years ago

I pushed a fix for this: b5f1b3af38ce0d24ed90d5f66a3ab10778e39e7a

It removes the float from bigbox ads and adds an overflow:auto to prevent collision with the XL and XXL figures. Seems to work in all my local browsers and it also has the advantage of preventing the ads from straying away from where they're actually marked up in the html.

The floats are pretty fussy so we should do some testing in preview before deploying publicly.

MrBryan commented 8 years ago

Seems to work on FF & chrome wherever I tested it , it's live now

alexgreen commented 8 years ago

(^_^)b Thanks! Glad we've got a solution that keeps the elements in order and also provides more control to editorial.