TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

Tyee Presents styling is inconsistent in Latest Stories #353

Closed alexgreen closed 8 years ago

alexgreen commented 8 years ago

Sometimes it appears, sometimes not. Especially when I click past it and then reverse back to it the styling is always missing.

screen shot 2016-09-29 at 9 42 16 pm screen shot 2016-09-29 at 9 42 06 pm

MrBryan commented 8 years ago

nice catch - fixed that with a commit.. haven't deployed yet as I'm looking at a bigger fix or possibly rewrite of that scroller. What it does is loads placeholders, then when you click on next it goes and ajax replaces each element in each placeholder through a bunch of complex functions and it has bugs (if you click previous a few times it will fail for a few clicks until all the odd number of stories per scroll are balanced out) that are complicated to fix.

I think it would be better to just load the stories in a long list then the next and previous buttons reveal the content by adjusting its position within the viewing area like normal scrolls. Or make use of a plugin that makes that shorter.

MrBryan commented 8 years ago

possibly sally was doing it this way to keep the initial load low but with the smaller thumbnails this shouldn't be an issue and I think the pagespeed extension will handle this, too

MrBryan commented 8 years ago

Fixed

alexgreen commented 8 years ago

I think it would be better to just load the stories in a long list then the next and previous buttons reveal the content by adjusting its position within the viewing area like normal scrolls.

I agree. It would also make it functional on medium touch screens views (e.g. ipads which don't allow any scrolling of Latest Stories).

possibly sally was doing it this way to keep the initial load low but with the smaller thumbnails this shouldn't be an issue and I think the pagespeed extension will handle this, too

Yes this is why she did it.