search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

Drop Cap bug #357

Closed alexgreen closed 7 years ago

alexgreen commented 7 years ago

As an aside- the drop cap is very broken on http://thetyee.github.io/design-article.thetyee.ca/legacy-small-image for me on chrome

Looks like this is happening because you disabled the overflow control on the lead-in paragraph: https://github.com/TheTyee/design-article.thetyee.ca/commit/aaaba695a7003cdd89c3ec052605fbed89d35e33 It affects other pages on github.io not just the legacy-image pages. E.g.: http://thetyee.github.io/design-article.thetyee.ca/library

Can you demonstrate why the overflow needs to be disabled?

From what I see the drop cap isn't getting applied at all on live articles with medium images: http://thetyee.ca/News/2016/06/30/China-Refusing-to-Recognize-Canadian-Citizenship-of-Travellers/ http://thetyee.ca/News/2016/06/25/Help-North-Korean-Refugees/ Is that a bug?

alexgreen commented 7 years ago

I've reapplied the overflow control: e23b8905005e43df6dec65b38760e0658fcb5c64