search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

Banner ads not showing on article pages #367

Closed alexgreen closed 7 years ago

alexgreen commented 7 years ago

... Despite multiple refreshing. Issue on nexus phone and on iPad mini. But the banner ads DO up on the home page (but only on iPad and only in landscape vote). image

image

MrBryan commented 7 years ago

This was set in the ad loading settings (code wrapped by addSize() ) - i moved the minimum down to 727 pixels which i believe those devices viewports are and that make them visible.