search

TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

How to apply proper height to latest story items? #376

Closed alexgreen closed 2 years ago

alexgreen commented 7 years ago

There seems to be javascript that's hardcoding a height into the html of latest story items. (See screen shot.) When I include the header (organisms/global/header.html) in the new index pages this height doesn't get applied, resulting in a broken latest-stories layout. What needs to be done for header.html object to work consistently on all pages?

screen shot 2017-02-23 at 10 45 47 pm

MrBryan commented 7 years ago

Basically on window.ready it loops the items in the list and finds the tallest one and then makes them all that height + a buffer. As long as the elements haven't changed their location/attributes it should still work - have any class names or object nesting changed ?

On Feb 23, 2017, at 10:53 PM, alexgreen notifications@github.com wrote:

Assigned #376 to @MrBryan.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

alexgreen commented 7 years ago

No change I'm aware of. I just included organisms/global/header.html like the story pages do:

`{% include meta/head.html %}

{% include 01-molecules/messaging/alerts--browser-support.html %} {% include 02-organisms/sections/httpswarning.html %} {% include 01-molecules/blocks/ad-banner.html ad-source="UBCMUD-leaderboard.jpg" %} {% include 02-organisms/global/header.html %} {{ content }}`
MrBryan commented 7 years ago

That was a pretty hacky fix in the first place maybe a good time to do it right and truncate length of text with eclipses and get a consistent height

Sent from my iPhone

On Feb 24, 2017, at 11:02 PM, alexgreen notifications@github.com wrote:

No change I'm aware of. I just included organisms/global/header.html like the story pages do:

`{% include meta/head.html %}

{% include 01-molecules/messaging/alerts--browser-support.html %} {% include 02-organisms/sections/httpswarning.html %} {% include 01-molecules/blocks/ad-banner.html ad-source="UBCMUD-leaderboard.jpg" %} {% include 02-organisms/global/header.html %}

{{ content }}` — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.