TheTyee / design-article.thetyee.ca

Working in the open on The Tyee's new article page design
http://thetyee.github.io/design-article.thetyee.ca/
Creative Commons Zero v1.0 Universal
3 stars 0 forks source link

Hotfix needed to mobile subscription form #382

Closed phillipadsmith closed 6 years ago

phillipadsmith commented 6 years ago

Hey there @MrBryan

Just found this high-priority bug: https://github.com/TheTyee/design-article.thetyee.ca/blob/63f4e85099268432d13fd08d2f33bfe48e789269/_includes/01-molecules/blocks/messaging-block--subscribe.html#L34

On the mobile form, the weekly option is set to daily. Instead of making the change as part of the work I'm doing, I was thinking it might be faster for you to fix it up and then I can rebase off of your changes.

Phillip.

MrBryan commented 6 years ago

I committed to develop.. went to pull onto bc-bricmod but there are changes in that file on server & article_custom.js -- was that me? Assuming you would never work on the server.... ;)

phillipadsmith commented 6 years ago

That was you! ;)

Sent from a phone. Please excuse the brevity and typos.

On Dec 28, 2017, at 8:04 AM, MrBryan notifications@github.com wrote:

I committed to develop.. went to pull onto bc-bricmod but there are changes in that file on server & article_custom.js -- was that me? Assuming you would never work on the server.... ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

MrBryan commented 6 years ago

Merged it ok to preview -- The subscribe form is pointing https://preview.webhooks.thetyee.ca/subscribe on preview which is down atm so fails -- seems to be via the "proxyAPI" variable switch.

But when I merged to live it would fail on the subscribe button saying " proxyAPI" not defined even when I would manually run enableEmailSubscribe() function that defines it.. So I rolled back & did a hotfix on live for that typo for now... preview has it merged

phillipadsmith commented 6 years ago

Can you re-merge the develop branch into preview (only!) kind Sir @MrBryan ? I've fixed the proxy URL so testing should be working again.

MrBryan commented 6 years ago

Done :) didn't commit the merge in case :)

phillipadsmith commented 6 years ago

This is closed, yes?