Font not updating on Android

TheUniforms / Uniforms-Misc

Various UI helpers for Xamarin.Forms

https://www.nuget.org/packages/Uniforms.Misc/

Apache License 2.0

7 stars 2 forks source link

Font not updating on Android #1

Open mathjeff opened 3 years ago

mathjeff commented 3 years ago

I'm observing that calling GetTextSize twice on Android with two different fonts is resulting in the second call reusing the font from the first call, causing the second call to return the wrong size.

I think this could be fixed via https://github.com/mathjeff/Uniforms-Misc/commit/7f0a7ef3db79c7082ed6760ced84da5ef6bbbe5d .

rudyryk commented 3 years ago

Hi Jeff @mathjeff, I've merged the PR. But also I'm currently not actively developing under Xamarin platform. I could add you as organization collaborator if you don't mind.

mathjeff commented 3 years ago

Hey thanks for merging it.

Re being an organization contributor, I don't have much opinion; I don't mind. I'm not currently familiar with the process of releasing a nuget package or with what kind of testing or code review is appropriate for this particular library, but I am using the text measurement portion of this library and I could potentially make a couple more updates eventually.