search

TheUnlocked / Better-Mixer

Improvements to Mixer, similar to FFZ for Twitch.
http://bit.ly/bettermixer
MIT License
9 stars 12 forks source link

Make a Firefox version of Better Mixer. #21

Closed KaylaMcTear closed 5 years ago

KaylaMcTear commented 5 years ago

Please can we have a add on for firefox :)

TheUnlocked commented 5 years ago

Due to Mozilla's lengthy review process for each update, I have stayed away from supporting Firefox. I could try to get Better Mixer on Firefox, but it would update much less frequently than the Chrome version.

KaylaMcTear commented 5 years ago

Right thanks didn't know the ins and outs of the upload process for Firefox. Tho i have found that Mixer is slightly buggy on there unlike chrome. so probs best not to do one i don't know

On Tuesday, 30 October 2018, 02:23:01 GMT, Unlocked notifications@github.com wrote:

Due to Mozilla's lengthy review process for each update, I have stayed away from supporting Firefox. I could try to get Better Mixer on Firefox, but it would update much less frequently than the Chrome version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

cfultz commented 5 years ago

I was able to get the code working and signed by Firefox in under 20 minutes. The only issue I'm seeing is that the animated emotes from BTTV are not showing correctly on mixer.

The below is literally a simple git clone, zipped the Extension directory, and signed it through Mozilla's tools. Again, I will look into how to get the animated emotes working and see if we can merge that into the master if you are alright with this? Thanks for your hard work!

Firefox: better_mixer-2.6.5-fx.xpi.zip

TheUnlocked commented 5 years ago

Yes, if you can get that working I'd accept a PR. Thanks.

TheUnlocked commented 5 years ago

Looking into this actually got a bug fix 😃 (2ee1e6624871809f4c06efab48013ae06818c42c)

I see two errors that keep popping up:

"storage.sync" can cause issues when loaded temporarily

Warning: This API can cause issues when loaded temporarily using about:debugging in Firefox unless you specify applications|browser_specific_settings > gecko > id in the manifest. Please see: https://mzl.la/2hizK4a for more.

Unsafe assignment to innerHTML

Warning: Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.

The former is potentially something that needs to be resolved. The latter is unlikely to cause any problems, but if we can appease the Mozilla gods that would be nice. I'll look into the latter so see if my innerHTML assignments are actually necessary where I use them (especially since I've tried to move away from assigning to innerHTML and towards more procedural DOM manipulation).

Edit: Every instance of innerHTML assignment could easily be replaced with an innerText assignment, with the exception of the innerHTML assignments within the jquery dist. Perhaps this is a good sign that I should just stop packing jquery with the extension and instead inject it into the site from a CDN like a normal person, but that's an issue for another time.

TheUnlocked commented 5 years ago

Once the submission process completes, the extension will be available on Firefox at https://addons.mozilla.org/en-US/firefox/addon/bettermixer/