search

TheVilleOrg / phpbb-groupsub

This is a extension for phpBB3 that allows you to create paid subscriptions for members to gain access to usergroups.
https://www.phpbb.com/customise/db/extension/groupsub/
GNU General Public License v2.0
10 stars 11 forks source link

Return(Thank You) Page for Unlimited Subscription gives 0 days/months/years #4

Closed Dark1z closed 5 years ago

Dark1z commented 5 years ago

The Return(Thank You) Page for Unlimited Subscription gives 0 days/months/years instead of Unlimited. For Example : 1 Where it should be like : 2 Similar to line : https://github.com/stevotvr/phpbb-groupsub/blob/master/styles/all/template/package_list.html#L46

Thanking you , Best regards 👍

stevotvr commented 5 years ago

Thanks for the report. That should be easy to fix.

stevotvr commented 5 years ago

Should it say

You have subscribed to X for unlimited time.

or

You have started an unlimited subscription to X.

or something else?

Dark1z commented 5 years ago

@stevotvr .

I think it's better to be first one , "You have subscribed to X for " , Coz it's common for all cases... Just change "0 xxxx" to "Unlimited" , assuming you will add " time." at the end.

Else it's better to change this line : https://github.com/stevotvr/phpbb-groupsub/blob/master/language/en/common.php#L47 to "Lifetime", one word like before and specifically for time.

Thanking you, best regards 👍

stevotvr commented 5 years ago

Fixed in https://github.com/stevotvr/phpbb-groupsub/commit/c92d995a41ed179c5200512a7feef37069bee8c3

"Lifetime" might not be applicable to all situations so I think I'll leave it as "Unlimited."

Dark1z commented 5 years ago

Ok... Thanks... 😄