Uploads time out on large files

TheWaWaR / simple-http-server

Simple http server in Rust (Windows/Mac/Linux)

MIT License

2.53k stars 170 forks source link

Uploads time out on large files #102

Closed NeoTheFox closed 4 months ago

NeoTheFox commented 6 months ago

Uploading anything large, say, 4 gigs file causes the browser to spew ERR_CONNECTION_RESET error. I suspect it might have something to do with Irons Timeouts, the default is set to 30 seconds, putting a hard limit on upload size. Possible solutions are:

Disable the timeout entirely
Introduce a timeout command line argument
Dynamically adjust timeout based on average upload speed times upload size. This one is elegant but involves a guessing game.

TheWaWaR commented 6 months ago

I may choose case 2 since it is easy to implement and provide some flexibility.

TheWaWaR commented 6 months ago

@NeoTheFox Did you specified the upload size limit? The default value is less than 8MB, and will case the program panic.

kesipyc commented 5 months ago

It works for me. I've just uploaded 9GB file, that took over 9 min through WIFI. I did use "-l" to set limit to 1TB. I'm on Windows x86_64 0.6.8.

TheWaWaR commented 4 months ago

I think it's already fixed in https://github.com/TheWaWaR/simple-http-server/commit/0806b006b9ea1388e551ce1af84b01db9e909fcb

Please comment below if you still have the same problem.