search

TheWaveWarden / odin2

Odin 2 Synthesizer Plugin
GNU General Public License v3.0
556 stars 52 forks source link

Learned MIDI bindings are not restored with Ardour #324

Open xard-dev opened 3 years ago

xard-dev commented 3 years ago

Describe the bug Odin2 forgets learned MIDI assignments after loading saved Ardour session and all MIDI bindings have manually each time a project is opened.

To Reproduce Steps to reproduce the behavior:

  1. Create session in Ardour and add Odin2 MIDI track.
  2. Open UI and setup instrument.
  3. Bind MIDI CC input to any control widget using the MIDI learn function.
  4. Create Midi material which uses these bindings and verify that they work.
  5. Save session.
  6. Close Ardour.
  7. Reopen Ardour and load saved project.

Expected behavior In reopened project learned MIDI bindings are assigned as they were before closing the project.

Desktop (please complete the following information):

EgonTwo commented 3 years ago

This happens to me as well, in Cakewalk by BandLab. MIDI learn works during session, but no longer show up in new session. Thanks!

porzione commented 3 years ago

Bindings are lost in standalone mode too Odin 2.2.4 Arch Linux Arturia MiniLab mk II

But otherwise it's just the best and stable synth!

TheWaveWarden commented 3 years ago

Bindings are lost in standalone mode too Odin 2.2.4 Arch Linux Arturia MiniLab mk II

But otherwise it's just the best and stable synth!

Everything is lost in standalone mode. As I primarily used it to develop I didn't want the synth to keep its state every time I open it. The following line and following disable saving in standalone: https://github.com/TheWaveWarden/odin2/blob/382505316e393390318332d6a5d8778b1aa3e9e8/Source/PluginProcessor.cpp#L846

porzione commented 3 years ago

Well, I got it. Same issue with last Qtractor (0.9.18) - no bindings after restart.