search

TheWaveWarden / odin2

Odin 2 Synthesizer Plugin
GNU General Public License v3.0
572 stars 53 forks source link

[Feature Request] Ability to reduce polyphony #442

Open TabulaNul opened 2 years ago

TabulaNul commented 2 years ago

Is your feature request related to an issue? Please describe. I'm using Odin2 with a custom Raspberry Pi synth (Zynthian Synth). It's a 32 bit OS, but jofemodo (one of the guys behind the Zynthian project) built it to make it work.

As you know, Raspberry PI 4 is a system with less resources than a regular computer. Odin 2 works well, but we experienced a few issues. When we put too much Amp Release, we observe "CPU clicks sounds" and XRUNS.

So we want to reduce the polyphony. Currently, we only have 3 options: Legato, Retrig (Mono) and Polyphony (24 voices, referring to your manual)

Describe the solution you want Possibility to reduce the polyphony (2, 3, 4, 5, 6, etc.)

System : Raspberry Pi 4 Model B Rev 1.2 Raspbian GNU/Linux 10 (buster)

TheWaveWarden commented 2 years ago

Hi @TabulaNul!

Since you've built from source already, have you considered reducing the polyphony in code? You'd have to change one line only: https://github.com/TheWaveWarden/odin2/blob/89aa4a0073cb73d866e8d78b62e23f7ae4577795/Source/GlobalIncludes.h#L71

Otherwise I'm unlikely to add dynamic polyphony restrictions to the project right now, sorry.

TabulaNul commented 2 years ago

hi !

Thank you for answering so fast ! Great, I think we're going to manually change the number of polyphonies allowed directly from the code! Thanks again!

TheWaveWarden commented 2 years ago

Ok cool! Just a word of warning: When using the unison tab, I'm not sure what will happen if you select lets say 6 voice unison, but the synth provides less voices.

So you might want to use at least 6 voices or just not use the unison feature at high note counts!