Add helpers for retrieving IDs for health check type, routing method,…

TheWeatherCompany / softlayer-go

A SoftLayer client API written in Golang

Apache License 2.0

5 stars 3 forks source link

Add helpers for retrieving IDs for health check type, routing method,… #41

Closed tmulhern3 closed 8 years ago

tmulhern3 commented 8 years ago

… and routing type

renier commented 8 years ago

@tmulhern3 Looks good. They only thing I would say, and this is something you can see in general in softlayer-go, there is a lot of code duplication between the helper methods now. Do you think we can put the commonality into another function? The unmarshaling and lookup would have to be unique, as well as the filters and const being used. For the former, would have to possibly pass an anonymous function to the common function to perform unmarhsal/lookup.

tmulhern3 commented 8 years ago

@renier good idea. Guess I got a little lazy there haha

renier commented 8 years ago

👍