search

TheWeatherCompany / softlayer-go

A SoftLayer client API written in Golang
Apache License 2.0
5 stars 3 forks source link

Remaining virtual guests CRUD changes #6

Closed igoonich closed 8 years ago

igoonich commented 8 years ago

Changes with respect to issue https://github.com/TheWeatherCompany/terraform/issues/5. Should be merged befor that issue.

danielcbright commented 8 years ago

Ivan, the PR to maximilian/softlayer-go is failing: https://travis-ci.org/maximilien/softlayer-go/builds/95575499 can you please take a look?

I've already changed the github paths back to normal.

-Daniel

On Thu, Dec 3, 2015 at 12:50 PM, Ivan Goonich notifications@github.com wrote:

Changes with respect to issue TheWeatherCompany/terraform#5 https://github.com/TheWeatherCompany/terraform/issues/5. Should be

merged befor that issue.

You can view, comment on, or merge this pull request online at:

https://github.com/TheWeatherCompany/softlayer-go/pull/6 Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/TheWeatherCompany/softlayer-go/pull/6.

igoonich commented 8 years ago

Hi @danielcbright,

According to travis logs go failed while fetching library godep. So it seems it is not actually related to our chnages: image

Can I restart this travis job somehow to be sure that it is not a temporary issue, because I cannot reproduce it locally?

danielcbright commented 8 years ago

I can do another PR later today and test, thanks for pointing that out Ivan

On Tue, Dec 8, 2015 at 10:32 AM, Ivan Goonich notifications@github.com wrote:

Hi @danielcbright https://github.com/danielcbright,

According to travis logs go failed while fetching library godep. So it seems it is not actually related to our chnages: [image: image] https://cloud.githubusercontent.com/assets/5939328/11659524/b8608b98-9dd9-11e5-880e-10792643e148.png

Can I restart this travis job somehow to be sure that it is not a temporary issue, because I cannot reproduce it locally?

— Reply to this email directly or view it on GitHub https://github.com/TheWeatherCompany/softlayer-go/pull/6#issuecomment-162916707 .

igoonich commented 8 years ago

@danielcbright, I've created one more PR. There might be a warning at stage Vetting packages for potential issues... for one of the fields as soon as Travis succeeds to fetch godep. This PR will resolve that warning - https://github.com/TheWeatherCompany/softlayer-go/pull/11.

danielcbright commented 8 years ago

Same error unfortunately: https://travis-ci.org/maximilien/softlayer-go/builds/95639957

On Tue, Dec 8, 2015 at 10:50 AM, Ivan Goonich notifications@github.com wrote:

@danielcbright https://github.com/danielcbright, I've created one more PR. There might be a warning at stage Vetting packages for potential issues... for one of the fields as soon as Travis succeeds to fetch godep. This PR will resolve that warning - #11 https://github.com/TheWeatherCompany/softlayer-go/pull/11.

— Reply to this email directly or view it on GitHub https://github.com/TheWeatherCompany/softlayer-go/pull/6#issuecomment-162923921 .

igoonich commented 8 years ago

Hi @danielcbright,

I've just checked the following tab of other latest Travis builds of softlayer-goand it has the same errors with godep: https://travis-ci.org/maximilien/softlayer-go/builds

So, it looks like the same building error appeared even 13 hours ago for another builds of maximilien. As far as I understand, it is not actually related to our latest PR, but to TravisCI softlayer-go building environment itself.

Probably GOPATH is wrongly configured there, as it fails to find build.MultiplePackageError.