TheWebShop / bootstrap-shortcodes

Wordpress plugin to add shortcodes for Twitter Bootstrap 3.0
36 stars 15 forks source link

Added functionality for Wells #1

Closed beaurixon closed 11 years ago

beaurixon commented 11 years ago

http://getbootstrap.com/components/#wells

Sinetheta commented 11 years ago

Wow, so you're gonna force me to clean up this repo already? :wink:

Thanks for the addition Beau, everything looks good to go!

Do you have a Wordpress profile that I can attribute the contribution to?

beaurixon commented 11 years ago

Sure thing Kevin here it is. http://wordpress.org/support/profile/beaurixon

Thanks for the inclusion.

Sinetheta commented 11 years ago

No problem, but is there a reason for this plugin to exist now that there's easy-bootstrap-shortcodes ?

I went to the trouble of updating dw-shortcodes-bootstrap for Bootstrap 3 because it didn't look like that project was active, and I didn't see anyone else had implemented it. Am I missing something or have these guys already nailed all the features I didn't bother implementing?

beaurixon commented 11 years ago

I did have a play with easy-bootstrap-shortcodes and I was in two minds which one to use. I chose your version because it includes the main elements my clients need. For easy-bootstrap-shortcodes I would need to see settings where I can select what WYSIWYG buttons to show dependant on the different access roles.

in my assessment I also feel easy-bootstrap-shortcodes has some complex input options to when implementing shortcodes that are confusing for the average user.

I am happy to keep developing this one further and I've already taken a look at what else I would like to see implemented.

Sinetheta commented 11 years ago

Well, that's enough justification for me.

One thing I wanted to implement before fleshing out the other bootstrap elements was precisely that, an options page to chose which shortcodes are available. I'm terrified to hand over the ability to add tabs and accordions to "content owners".

Thanks for the interest Beaux, feel free to make radical changes as well. I'm not too impressed by the structure of the plugin, I was just trying to update the existing DW bootstrap shortcodes as quickly as possible for Bootstrap 3.

beaurixon commented 11 years ago

Thanks Kevin.

At least Tabs and Accordions are more manageable than Tooltips and Popovers. Could you imagine the disasters "content owners" could create with these. :)

I'm very limited with PHP and JS only the basics so I'll leave the options page up to you. I will play around with icons (https://github.com/beaurixon/bootstrap-shortcodes/commit/9e7d4563ce49fcfa2ba907ca45d0114eb4951738) and styling though.

p.s. Is there a reason it's not showing correctly on WP.org any more. (wordpress.org/plugins/bootstrap-shortcodes/)

Sinetheta commented 11 years ago

Wow, thanks for spotting that. I must have somehow dragged another plugin's readme.txt into the official repo when I was making an update. It should be fixed now.

It's a problem with trying to accommodate Wordpress.org's use of SVN while maintaining the true source on GitHub. I'm sure SVN is a great system, but personally I prefer that instead of a request for support on the forums, I received a pull-request this morning with a new feature!

beaurixon commented 11 years ago

True. Much better doing pull requests.

beaurixon commented 11 years ago

Kevin, do you think when you create the 'options' page you could include a tick box to include or not include bootstrap.css?

The reason is, I'm already developing with bootstrap and have included the bootstrap css manually in the header. My style css then overrides only what's needed. When I was testing the plugin on some client sites it overrode my styles. As a quick fix I could put my css under <?php wp_head(); ?>, however in some cases I'm customising bottstrap.css using LESS and this totally defeats the purpose long term.

Let me know your thoughts?

beaurixon commented 11 years ago

Ahh. I see you already have this in the options. Must have missed this. Disregard my last message. Thanks

Sinetheta commented 11 years ago

No prob, those two options came with it. Sorry I didn't get a chance to add the other options yet.