TheWebShop / bootstrap-shortcodes

Wordpress plugin to add shortcodes for Twitter Bootstrap 3.0
36 stars 15 forks source link

It ads offset class from bootstrap2 .... #24

Closed izoweb closed 10 years ago

izoweb commented 10 years ago

It ads offset class from bootstrap2 .... is was not supposed to use col-md-offeset1-1 for example ... instead of adding another class named offset1 ... maybe i'm just noob. can you verify ? thanks !

No3x commented 10 years ago

Hi @izoweb the issue is not very clear to me. Could you provide further examples/screenshots?

izoweb commented 10 years ago

Hi @No3x Sure !

For example on that page http://getbootstrap.com/css/

It uses col-md-4 and col-md-offset-4 to offset columns but the plugin here is adding a class "offset2" for example instaead, i thinkk this is from bootstrap 2... not 3...

here a screenshot of what the shortcode from the custom tab generates. https://dl.dropboxusercontent.com/u/369715/IZO/bootstrapshortcodeplugin.jpg

as you can see there is no offset1 or 2 or 3 etc.. associated to this... maybe because i added the bootstrap files manualy ? *\ i disabled css and js import from the plugin options...

thanks !

izoweb commented 10 years ago

Almost forgot... is there a way to use col-md-6 instead of col-xs-6 from the shortcodes ?

No3x commented 10 years ago

Okay I understand the problem. Did you use the grid-wizard of the plugin?

If yes: it seems to generate BS2 optimized mark-up. BS3 doesn't use .offset* any more but .col-md-offset-* - seems like the grid-wizard needs a revision. (http://getbootstrap.com/2.3.2/scaffolding.html#fluidGridSystem)

You asked if you could use col-md instead of col-xs: At the moment there is no option to select between .col-xs- .col-sm- .col-md- .col-lg- (they control the appearance behaviour on different devices. (http://getbootstrap.com/css/#grid-options). But this could be a requirement for the next revision of the grid-wizard.

Cheers, No3x

izoweb commented 10 years ago

yes i used the custom grid wiz yes as i told you, it ads bs2 code instead of bs3 i know what is md or xs, it would be nice to have the choice. thanks !

No3x commented 10 years ago

Sure you know what the classes are for. I just try to sum things up so that everybody can get a good overview about the issue and could patch the wizard on their own with the given information and references.

izoweb commented 10 years ago

Oh ok sorry... I'm not sure if it will be fixed or if you told me any tips to solve the issue :S

No3x commented 10 years ago

Sorry I can't estimate a fix. Fixing the issue would require a revision of the grid wizard. If you want you can give it a try. Files that require an adaptation are: inc/bs_grid.php js/plugins/grid.html js/plugins/grid.js Otherwise maybe someday somebody will have a look. Workaround: you don't use the wizard and use plain html mark-up.

Maybe @Sinetheta can give some more information to solve this issue.

izoweb commented 10 years ago

Thanks

Sinetheta commented 10 years ago

Thanks for spotting this guys, I've fixed the class issue and updated the look of the wizard a bit. Let me know if everything's cool now.