wp 3.9

[Firestorm-Graphics]

incompatible with wp 3.9 and tinymce 4, createControl is now deprecated

[Sinetheta]

[Danny159]

Any news on this? As its stopped working on all my websites now?

[Sinetheta]

Sorry @Danny159 I haven't had time to address this myself, but I'd be happy to merge in any fixes.

Alternatively, this would be a good place for discussion of the update path. If tinymce.createControl is gone, what's taking it's place? If someone could suggest a replacement or find code samples online, I'm sure it would greatly speed up this process.

[No3x]

Hi @Sinetheta & the others. I've taken a look into the changes and want to share some thoughts:

• I was able to migrate the alerts as practice how to include plugins since 4.0. See https://github.com/No3x/bootstrap-shortcodes/commit/18f4ded8861969be3297bc196871bad6db76c8b3 please note the comment
• I'm still not sure what's the common/compatible way to include plugins now.
• The filter mce_buttons_3 doesn't work any more. But I can't say for sure. (changed to mce_buttons for now)
• The Try it section is very useful, but not sure if it is for 4.0. See http://www.tinymce.com/tryit/menubutton.php

[No3x]

After hours of trying things I have to say that it seems that tinymce 4 is not meant to be backwards compatible.

• No splitbutton anymore with same code for tinymce 3 & 4. (I was not able to do that) Does anybody know plugins that use splitbutton for 3 & 4? The question is: Do we need backwards compatibility for pre 3.9? Imho I think so..
• Does anybody tried the 'compat3x'? See http://www.tinymce.com/wiki.php/Plugin:compat3x
• Does anybody know open source wp plugins that work well on 3 and 4?

[Sinetheta]

@No3x it seems that way, and thanks for doing some experimentation.

It kinda blows my mind how little info there is online about the differences between 3 and 4 or how plugin authors might tackle updates (besides that silly compat plugin targeted at users).

[Firestorm-Graphics]

ive created a premium plugin using the new tinymce 4, i dont do backwards compatibility with wp as it should be kept up to date, but maybe you could check wp version in php and include the right js dependant on wp version

[Firestorm-Graphics]

split button is in tinymce 4, ive used it in my plugin

[No3x]

@Sinetheta I agree with the little amount of information available online. @Firestorm-Graphics Yes split button is in 4 for sure but I've talked about the use of compatible code for 3 and 4 as well. I can't use split button in a new plugin version target wp 3.9 without breaking it for all users on versions prior 3.9. (we would need an abstraction/compbatibility layer [what the compat3x could be]).

By the way I really like the changes made in the new version of tinymce 4.

[Sinetheta]

Like @Firestorm-Graphics I tend to favour a simpler plugin over backwards compatibility, this thing's ugly enough as is. Besides, if your WP isn't up-to-date you've got bigger problems than some missing WYSIWYG helper buttons :wink:

[No3x]

All right! So that's a clear direction.

[Danny159]

I agree, keep it simple and working with the latest.

[No3x]

Hey guys, I've ported the plugin to 3.9. (https://github.com/TheWebShop/bootstrap-shortcodes/pull/27) There is a lot of testing/improvement/refactoring required especially:

• the css (hovering & active effects are removed because all the other plugin buttons in tinymce 4 spare such effects)
• there was a lot of copy/paste work but less behaviour changes so mistakes (on my part) should be easy to spot.
• the label plugin was not working properly ( the content from the shortcode was not translated to the label )
• the collapse plugin was also not working properly because sometimes (often on items more than 10) the random number for the items was not unique. So I introduced the guid() function. Please delete the comment //Math.floor((Math.random()*100)+1); https://github.com/TheWebShop/bootstrap-shortcodes/blob/master/js/plugins/collapse.js#L19

The mce_buttons_3 didn't work until all problems in the plugins had been resolved - but now everything is fine.

22, #15 should be solved by this.

[Danny159]

Nice one @No3x looks good, I will test.

[Sinetheta]

:100: I'll close this issue once everything's live in the wordpress plugin repo, but huge props to @No3x for tackling this migration!