search

TheWebShop / bootstrap-shortcodes

Wordpress plugin to add shortcodes for Twitter Bootstrap 3.0
36 stars 15 forks source link

Make the default bootstrap column breakpoint sm, not xs #49

Closed emRae closed 9 years ago

emRae commented 9 years ago

Hello,

Thank you for putting this plugin together. In using it the one fatal flaw I noticed is that the default breakpoint class size is set to xs. I believe more people would like their columns to go to 100% width for phone / small devices than have them keep their original width.

The changes I made will switch the default breakpoint class size to sm, instead of xs. IMO, this makes the columns more responsive friendly.

Thanks, :: Rachel

Sinetheta commented 9 years ago

I think this is a reasonable change @emRae. I'd like to test it out before merging though since there are quite a few changes.

Sinetheta commented 9 years ago

I've cherry-picked these commits in https://github.com/TheWebShop/bootstrap-shortcodes/commit/16dd20b0d074156a2f7a2373c0d7aa935c79343f https://github.com/TheWebShop/bootstrap-shortcodes/commit/e72e4ff7ab3a5b48476189dce236dfaf5286cf7f but without the .replace(/xs/g, "sm") which didn't do anything. Thanks @emRae !