search

TheWebShop / bootstrap-shortcodes

Wordpress plugin to add shortcodes for Twitter Bootstrap 3.0
36 stars 15 forks source link

Added support for tooltips. #9

Closed No3x closed 11 years ago

Sinetheta commented 11 years ago

Nice add @No3x! I should be able to test it this afternoon. Last time I blind merged I got bitten by a typo ;)

No3x commented 11 years ago

I can't notice a difference of 'show' and 'toggle' in the state. Is the tooltip.js plugin already in the bootstrap.js?

Sinetheta commented 11 years ago

Yes, the bootstrap.js is a full build. Which means that simply including the correct data attributes is enough to activate tooltips (the IDs and inlined scripts are redundant). I'm just having a go at editing the commits of your pull request a bit to remove the script tags and change the "state" to a "trigger" instead.

Sinetheta commented 11 years ago

Oh wow, I take it back. Bootstrap doesn't have automatic parsing for tooltips, you have to activate them manually. super lame.

Sinetheta commented 11 years ago

The fastest way for me to get this in is going to be just to accept the merge and then do a commit on my end. Thanks for the addition @No3x.