search

TheWebTech / CrankShaft

A framework for building modern websites on the HubSpot Platform.
https://thewebtech.github.io/CrankShaft
MIT License
46 stars 17 forks source link

Remove HubSpot Mobile Menu? #50

Open TheWebTech opened 5 years ago

TheWebTech commented 5 years ago

I can honestly say I never use this.

Do you guys? if a significant amount of people use it we can leave it in. I just think it's probably not well used.

https://github.com/TheWebTech/CrankShaft/blob/cc765662b1082515690dc5c98aeccbcb2797b55e/theme/theme_base.css#L350-L547

TheWebTech commented 5 years ago

Everything in: /mobile_nav is related

Andreas1281 commented 5 years ago

I agree, i also never use it.

TheWebTech commented 5 years ago

I think it's safe to remove. Lets remove everything in /mobile_nav as well as that css in theme_base.css

Whoever wants to hop on this go for it!

TheWebTech commented 5 years ago

72 addresses the theme_base.css changes but doesn't remove the /mobile_nav files so that's what's left on this issue.