search

TheWebTech / CrankShaft

A framework for building modern websites on the HubSpot Platform.
https://thewebtech.github.io/CrankShaft
MIT License
46 stars 17 forks source link

Create Table element styling #61

Open TheWebTech opened 5 years ago

TheWebTech commented 5 years ago

Create simple but visually decent table element styling. I suggest making a codepen and trying to build out a table there so you can see what you think. (if you do make a codepen, please share it here so we can see it)

This task is for specifically base table styling.

Mobile, modifiers and any other special functionality can come later, don't worry about that right now. We just need base table tr td thead type styling set up. If you WANT to do more go for it, it's just not expected.

All of the styling for the table element can go in cs-defaults.

If you want an example of what this could look like https://getbootstrap.com/docs/4.0/content/tables/ https://foundation.zurb.com/sites/docs/table.html

dennisedson commented 5 years ago

getting started here: https://codepen.io/billyoncetoldme/pen/BepyNR

TheWebTech commented 5 years ago

lookin' good! Seriously

TheWebTech commented 5 years ago

Something we haven't ever discussed and I don't know if it's actually a big deal - Twitter bootstrap makes it so a css class enables the table styles(the thought being in-case any plugin js or anything generates a table, then the styles wouldn't conflict)

obviously your base element tweaks aren't ones that are really going to cause something like that to get really weird

Personally though I do like that if they're based on the base table element it will work for marketers just adding tables in the hubspot rich text editors

adesignl commented 5 years ago

I think if you scope your styles you could make them easy to use even for a marketer.

Chad Pierce (727) 967-7358 cpierce@adesignlink.com

Schedule A Meeting: https://meetings.hubspot.com/cpierce2

On May 14, 2019, at 4:16 PM, Jon McLaren notifications@github.com wrote:

Something we haven't ever discussed and I don't know if it's actually a big deal - Twitter bootstrap makes it so a css class enables the table styles(the thought being in-case any plugin js or anything generates a table, then the styles wouldn't conflict)

obviously your base element tweaks aren't ones that are really going to cause something like that to get really weird

Personally though I do like that if they're based on the base table element it will work for marketers just adding tables in the hubspot rich text editors

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TheWebTech/CrankShaft/issues/61?email_source=notifications&email_token=AAF27WRH2TDTC24PMV72LQLPVMMYJA5CNFSM4HMZUQPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMVDCI#issuecomment-492392841, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF27WXRX6USIJITBO7XRNDPVMMYJANCNFSM4HMZUQPA.

TheWebTech commented 5 years ago

Just moved this issue to make it clear Dennis has started on this.

lol Chad your email signature with your meeting scheduling phone number and email address is pulling through to the github issues.

Not a problem from our end, but you might get robo calls, spam emails, and Dennis scheduling a meeting with you