search

TheWebTech / CrankShaft

A framework for building modern websites on the HubSpot Platform.
https://thewebtech.github.io/CrankShaft
MIT License
47 stars 17 forks source link

Convert Bootstrap's grid to a css file with HubL #8

Closed TheWebTech closed 5 years ago

TheWebTech commented 5 years ago

Creating this as an issue to make this easier to track and collaborate on. We want to take just the grid part of Bootstrap, and pull it into a css file that can be used on hubspot, ultimate goal being that we could use HubL to change some of the things that currently have sass variables in normal bootstrap.

minimum viable thing would be to just have the straight outputted CSS for the grid in this repo. Super awesome bonus would be having some hubl vars - not required though.

Even more awesome- if any of the css that's repetitive used hubl to generate it, making it easier to maintain. not required at all though.

Mark Ryba and AJ feel free to assign to yourselves too when you join. We can all collab on this.

TheWebTech commented 5 years ago

We'll use https://github.com/TheWebTech/CrankShaft/tree/grid-feature for working on this feature. Contribute to that branch. When working on the grid.

TheWebTech commented 5 years ago

To point out where we're implementing the grid code for anyone who wants to hop in and help https://github.com/TheWebTech/CrankShaft/blob/master/CrankShaft/code/cs/cs-grid.css#L441-L2532

Updated link to code.

dennisedson commented 5 years ago

We'll use https://github.com/TheWebTech/CrankShaft/tree/grid-feature for working on this feature. Contribute to that branch. When working on the grid.

the url 404s

TheWebTech commented 5 years ago

Sorry I merged that branch in. I'll update links to the files. To keep it clear where they are.

a new branch can be created for working on this.

TheWebTech commented 5 years ago

Let me know if you don't feel comfortable making your own branch or working in a fork, I can create a branch for it if necessary.

branch name can be whatever, just name it something related to the grid.

TheWebTech commented 5 years ago

I think this is actually fully done now, so anything we want to add is just improvements.