search

TheWeirdDev / lyrics-finder-gnome-ext

Finding lyrics has never been easier. Just play some music !
GNU General Public License v3.0
34 stars 3 forks source link

Doesn't work if the name includes Special Characters #6

Open nthcatalan opened 5 years ago

nthcatalan commented 5 years ago

if the artist name include a special character (ä, ö , ü, etc ) the lyrics is not displayed (despite being identified and showing as found).

some example artists: Ängie Trümmerwelten Leæther Strip

might also be a problem if the song title includes special characters, but haven't tested those.

excellent work. thank you.

update: presence of "Special Characters" might have been a false conclusion, because there have been other cases where the artist name did not include any special characters, yet the search shows Find:10 , but clicking on the search result does not show the lyrics, displaying lyrics not found.

I think this is because many lyrics website list the Song in their result even if there is no lyrics available.

TheWeirdDev commented 3 years ago

Hi, Sorry for the very late response.

I added some url encoding capability to the extension that might fix this issue. If it didn't get fixed, those song lyrics might not be available in the API provider that I'm using, and there is nothing that I can do about it.

Can you check if it is fixed and let me know?