search

TheWidlarzGroup / react-native-notificated

⚡️React Native toast notifications
https://thewidlarzgroup.github.io/react-native-notificated/
MIT License
386 stars 22 forks source link

docs: correct link of github #117

Closed ssavi-ict closed 2 years ago

ssavi-ict commented 2 years ago

Why

Closes #115

What Changed

Please check my PR and validate if OK. I am new to OS contribution. I will be grateful for any feedback. Thanks.

danielmark0116 commented 2 years ago

@ssavi-ict make sure that the PR title matches the Conventional commits and we can merge 👍🏽

ssavi-ict commented 2 years ago

Hello @danielmark0116 , Can you please check the current title? According to the mentioned link, the title should be consistent. I changed all the letters to lowercase.

Apologize for mistakes.

danielmark0116 commented 2 years ago

@ssavi-ict PR's title should also be prepended with a type, e.g.:

feat: my feature
fix: product modal bug fix
docs: add X paragraph

etc

so in this case, decs: {{your_title}} :)

If the pipelines pass, we can merge it :)

Thanks for your time!

ssavi-ict commented 2 years ago

@danielmark0116 Thank you for your kind guideline. I was not aware of that. I have changed as you mentioned. However, I see it is still showing the previously evaluated commit message. Can you please let me if it is OK?

danielmark0116 commented 2 years ago

Merging :) Thanks 👍🏽

ssavi-ict commented 2 years ago

@danielmark0116 Thank you for your help. I will keep these tips in mind from next.