TheWidlarzGroup / react-native-notificated

⚡️React Native toast notifications

https://thewidlarzgroup.github.io/react-native-notificated/

MIT License

365 stars 21 forks source link

refactor: create notification type #169

Closed jan-kozinski closed 1 year ago

jan-kozinski commented 1 year ago

Description

This branch tries to split up the createNotification types from implementation. Also it couples up the UseNotification type with the Emitter type as I can't think of any scenario in wich the Emitter api would have a different reason to change than the useNotification hook (alas, the duplication of those types violates DRY)

How to test?

Test as in the documentation. This PR aims to change no executed code behavior, only the types

Base branch

typescript-refactor

github-actions[bot] commented 1 year ago

🚀 📲 Application preview:

Scan with your mobile:

Expo QR

or visit this link:

Published to https://exp.host/@thewidlarzgroup/notificated-example-expo?release-channel=4949ae51ec75f26d83fb98a196dcec8486a42431