search

TheWidlarzGroup / react-native-video-player

A video player for React Native with controls
MIT License
516 stars 316 forks source link

Duration UI #138

Closed utpal-d4l closed 3 years ago

utpal-d4l commented 3 years ago

This PR adds duration in the UI. The current time also gets updated on seeking.

Screenshot 2021-10-07 at 10 01 06 PM Screenshot 2021-10-07 at 10 01 28 PM
utpal-d4l commented 3 years ago

@cornedor Please review.

TheDanielMoli commented 3 years ago

@utpal-d4l Make it optional and I'll merge (add a showDuration param).

TheDanielMoli commented 3 years ago

Merged and updated README, CHANGELOG and package.json. We'll need @cornedor to upload the build to npm, though.

utpal-d4l commented 3 years ago

Thanks, @TheRav3n.

utpal-d4l commented 3 years ago

@cornedor I need to use this in my project. Please upload the build to npm. Thanks.

cornedor commented 3 years ago

Thanks for the MR, will try to update asap

utpal-d4l commented 3 years ago

@cornedor Any updates on when the build will be updated?

TheDanielMoli commented 3 years ago

@utpal-d4l Dude, just do this:

// package.json
...
"dependencies": {

"react-native-video-player": "cornedor/react-native-video-player#master",}

....

Or do you have issues with it?

cornedor commented 3 years ago

The changes are published, v0.12.0