TheWidlarzGroup / react-native-video-player

A video player for React Native with controls
MIT License
516 stars 316 forks source link

Add fullscreen button in Android #52

Open isAlmogK opened 7 years ago

isAlmogK commented 7 years ago

The full-screen option is not showing on Andriod not sure why. I'm using the lastest version

"react-native-video": "^2.0.0",
"react-native-video-controls": "^1.3.0",
"react-native-video-player": "^0.8.2", 

Here is my code

<VideoPlayer
    endWithThumbnail
    thumbnail={{uri: selectedPhoto.url.thumbnail}}
    video={{uri: selectedPhoto.url.compressedFile}}
    disableFullscreen={false}
/>
cornedor commented 7 years ago

Fullscreen isn't fully implemented in Android yet, you can check out this pull request https://github.com/cornedor/react-native-video-player/pull/38. The readme has some instructions on how to set it up.

isAlmogK commented 7 years ago

@cornedor any reason the PR was not merged?

cornedor commented 7 years ago

If I do you have to manually copy the native code from a folder in node_modules. If you do not do that you get an error. I still have to put some time into getting this to work with react-native link

isAlmogK commented 7 years ago

@cornedor yea that would be great if it can work with jus react native link

bisht2ankit commented 6 years ago

Still full-screen option is not showing on Andriod

NitishAgrawal commented 6 years ago

Still full-screen option is not showing on Andriod

meliodev commented 4 years ago

Is there any update on this ? :(

TheDanielMoli commented 4 years ago

There is no solution worthy of being published yet. Feel free to look into it! Sadly, this feature requires consistent Java and Android knowledge.

aschambers commented 3 years ago

I have a fork of the repository to add the fullscreen button on Android. If you add the native module in Android for the video player in your app, it will show the fullscreen button and work: https://github.com/aschambers/react-native-video-player Of course this requires some knowledge of Android and Java though.

sinafbd commented 3 years ago

i have same problem after doing all the things mentioned for android full screen

ttibau commented 3 years ago

Some update here?