TheWidlarzGroup / react-native-video

A <Video /> component for react-native

https://thewidlarzgroup.github.io/react-native-video/

MIT License

7.19k stars 2.9k forks source link

Move startup props into a single configuration #2693

Open armands-malejevs opened 2 years ago

armands-malejevs commented 2 years ago

Feature Request

Create a new prop where all current props that are only used during initialisation and cannot be changed during runtime into a single configuration prop.

Why it is needed

This will make it more clear to developer as to which props can be changed during runtime and which props can only be provided when creating the player. This will also simplify the initialisation logic to get rid of postDelayed calls etc.

Tasks

[x] textTracks (external subtitle tracks)
[x] contentStartTime
[X] drm
[x] Ads props
[ ] bufferConfig
[x] minLoadRetryCountModifier

wood1986 commented 2 years ago

@freeboub and @armadilio3. Could you guys please come a list of props which is only for the player initialization? Any change to these props will be ignored after the initialization

fullscreen controls

wood1986 commented 2 years ago

I prefer breaking the people build in alpha after fixing this. I mean throw an exception when people still using original fullscreen and controls. Do you guys have any concerns?

freeboub commented 2 years ago

@wood1986 I already flag following props as 'startProps':

textTracks (external subtitle tracks)
bufferConfig
contentStartTime
drm
header
useTunnelingPlayback (a change from my working branch I need to backport)

The good news is that we should be able to implement this change without changing external API. in Video.js, we can get public input paramters and reformat then to provide it to native. That's my plan, but I have a lack of time :)

freeboub commented 5 months ago

localSourceEncryptionKeyScheme for ios shall be moved to source.drm.localSourceEncryptionKeyScheme

freeboub commented 1 month ago

localSourceEncryptionKeyScheme for ios shall be moved to source.drm.localSourceEncryptionKeyScheme

Done in: https://github.com/TheWidlarzGroup/react-native-video/pull/4136 thank you @KrzysztofMoch