search

TheWidlarzGroup / react-native-video

A <Video /> component for react-native
https://thewidlarzgroup.github.io/react-native-video/
MIT License
7.17k stars 2.89k forks source link

[Android] When controls is false, the presentFullscreenPlayer() does not work. #3231

Open nicolaosm opened 1 year ago

nicolaosm commented 1 year ago

Bug

Platform

Which player are you experiencing the problem on:

Environment info

Library version: V6 - Alpha 7 Device: Android Pixel 4

Steps To Reproduce

  1. set controls={false}
  2. call presentFullscreenPlayer() ...

Expected behavior

Video goes into full screen mode - Same as it would when we press on native Full Screen Icon.

nicolaosm commented 1 year ago

@freeboub I believe this issue is critical for release. Please review. Thanks

freeboub commented 1 year ago

I review behaviour between 5.2 & 6.0.0 it seems coherent, anyway I agree with you that the 'usage' is not really logic. I think we should define the expected behaviour for next major release. We can either discuss about it here on on slack if you want.

github-actions[bot] commented 2 days ago

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.