TheWidlarzGroup / react-native-video

A <Video /> component for react-native
http://thewidlarzgroup.github.io/react-native-video/
MIT License
7.13k stars 2.88k forks source link

[BUG]: Application Fails to Exit PiP Mode When Clicking on App Icon #3923

Open Sumeeth-24 opened 2 months ago

Sumeeth-24 commented 2 months ago

Version

6.2.0

What platforms are you having the problem on?

iOS

System Version

above 13

On what device are you experiencing the issue?

Real device, Simulator

Architecture

Old architecture

What happened?

When the application is in Picture-in-Picture (PiP) mode, clicking on the app icon does not restore the application to full screen. Instead, the application remains in PiP mode, displaying all the controls. The application only restores to full screen when the full-screen icon within the PiP window is clicked. However, clicking the application icon to restore it does not work as expected.

pip-issue

I think the issue is related to playInBackground props.

Expected Behavior:

Clicking on the application icon should restore the application to full screen mode, similar to the behavior when the full-screen icon within the PiP window is clicked.

Reproduction

https://drive.google.com/file/d/1K4D-t8FFnWFe2izXxUIsJeNf8OHH0XuE/view?usp=sharing

Reproduction

Step to reproduce this bug are:

  1. Launch the application
  2. Enter in PipMode
  3. Click on app icon instead of fullscreen icon of PipMode
freeboub commented 2 months ago

I thiink this should be something quiet easy to fix... @YangJonghun did you find and fix this issue with your PIP PR ?

ttnshubham commented 2 months ago

@YangJonghun Please let us know if you find any solution. Replicating same issue at my end

YangJonghun commented 2 months ago

@freeboub I haven't fix it

YangJonghun commented 2 months ago

@ttnshubham Does this also happen to you when using PR #3385?

ttnshubham commented 2 months ago

@YangJonghun Yes, I am using same PR and updated with your latest changes too, I can replicate it.

YangJonghun commented 2 months ago

@ttnshubham Thanks for letting me know, I'll check it out :)

ttnshubham commented 2 months ago

@YangJonghun, have you got any time for this issue?

YangJonghun commented 2 months ago

@ttnshubham I found cause but I need more time to fix it.šŸ„²