TheWidlarzGroup / react-native-video

A <Video /> component for react-native
https://docs.thewidlarzgroup.com/react-native-video/
MIT License
7.22k stars 2.9k forks source link

[BUG]: Clean version of package, Remove IMA SDK #3970

Open Rambos opened 4 months ago

Rambos commented 4 months ago

Version

6.3.0

What platforms are you having the problem on?

iOS, Android

System Version

33

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

I want to remove all IMA ads related information, including the word "ads" code. I used useExoplayerIMA false, but there is still the word "ads" code in the project, which will cause my app to be rejected in the app market.

How can I do this? Is it possible to have a clean version of the package?😆

I'm currently downgrading to version 5.x using

Reproduction

repository link

Reproduction

Step to reproduce this bug are:

freeboub commented 4 months ago

Can you share the store error please ? Because there is no solution yet ...

Rambos commented 4 months ago

In fact, no error was reported. Some testing tools in the application market automatically scanned the related words com.google.ads, thinking that adMob sdk was introduced, and a false positive occurred. I read the source code and found that the package name of com.google.ads.interactivemedia.v3.api does exist. Even though I turned on useExoplayerIMA false, I could still scan com.google.ads.

freeboub commented 4 months ago

@Rambos so play store requests you to register ads stuff ? In fact we implemented some stub to easily disable ads that's why these classes are available in your apk ... I think you should contact play store team to inform them it is a false positive while we try to remove it ...

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

freeboub commented 2 months ago

@Rambos Did you manage to push your app ?

ouabing commented 1 month ago

After upgrading from v5 to v6, our app is also rejected by some markets, because they scanned and found keywords "com.google.ads" in our app.