[BUG]: Changing resize mode to cover causing subtitles crop from bottom.

TheWidlarzGroup / react-native-video

A <Video /> component for react-native

http://thewidlarzgroup.github.io/react-native-video/

MIT License

7.14k stars 2.88k forks source link

[BUG]: Changing resize mode to cover causing subtitles crop from bottom. #4043

Closed rahulnainwalttn closed 1 week ago

rahulnainwalttn commented 1 month ago

Version

6.1.1

What platforms are you having the problem on?

iOS, Android

System Version

android 13, ios 15

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

A bug happened!

Reproduction

repository link

Reproduction

Step to reproduce this bug are: play any video with subtitles and try to change resize mode to cover.

KrzysztofMoch commented 1 month ago

On android should be fixed by https://github.com/TheWidlarzGroup/react-native-video/pull/3914

KrzysztofMoch commented 1 month ago

I will check iOS but It can be that this will be not possible to fix it :/

rahulnainwalttn commented 1 month ago

Is it possible to return a subtitle string to the React Native side and render it in React Native? Using an event like onProgress?

KrzysztofMoch commented 1 month ago

Yes you have onTextTrackDataChanged that should work on both platforms

rahulnainwalttn commented 1 month ago

We are not using external subtitle files.

freeboub commented 1 week ago

I confirm this is no more reproduce since: https://github.com/TheWidlarzGroup/react-native-video/pull/3830

freeboub commented 1 week ago

Please see last merged PR. The proposed change was causing a regression, the original behavior has been restored, so in next release you will have to add a prop to configure it.