search

TheWidlarzGroup / react-native-video

A <Video /> component for react-native
http://thewidlarzgroup.github.io/react-native-video/
MIT License
7.14k stars 2.88k forks source link

[BUG]: Kotlin warnings with :react-native-video:compileDebugKotlin task #4057

Closed VMBindraban closed 1 week ago

VMBindraban commented 1 month ago

Version

6.4.3

What platforms are you having the problem on?

Android

System Version

Mac

On what device are you experiencing the issue?

Real device

Architecture

New architecture with interop layer

What happened?

The :react-native-video:compileDebugKotlin task is giving some warnings:

react-native-video/android/src/main/java/com/brentvatne/common/api/ResizeMode.kt:45:5 This annotation is deprecated in Kotlin. Use '@kotlin.annotation.Retention' instead

react-native-video/android/src/main/java/com/brentvatne/common/react/VideoEventEmitter.kt:212:64 Parameter 'i' is never used, could be renamed to _

react-native-video/android/src/main/java/com/brentvatne/common/react/VideoEventEmitter.kt:306:43 Parameter 'i' is never used, could be renamed to _

react-native-video/android/src/main/java/com/brentvatne/exoplayer/FullScreenPlayerView.kt:64:15 'onBackPressed(): Unit' is deprecated. Deprecated in Java

react-native-video/android/src/main/java/com/brentvatne/react/VideoManagerModule.kt:45:45 Parameter 'tolerance' is never used

Reproduction

No response

Reproduction

Run react-native-video:compileDebugKotlin task

KrzysztofMoch commented 1 month ago

Did your build failed or is just gives warnings ?

VMBindraban commented 1 month ago

Did your build failed or is just gives warnings ?

Only warning. It builds just fine.

KrzysztofMoch commented 1 month ago
github-actions[bot] commented 1 week ago

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

freeboub commented 1 week ago

Linked prs are merged, can be closed