TheWidlarzGroup / rn-emoji-keyboard

Super performant, lightweight, fully customizable emoji picker 🚀
https://thewidlarzgroup.github.io/rn-emoji-keyboard/
MIT License
335 stars 63 forks source link

Skin selector modal stays when you swipe to a different category #135

Closed ManuViola77 closed 1 year ago

ManuViola77 commented 1 year ago

Describe the bug If you have opened the skin selector modal and you swipe to another category, the skin selector modal doesn't close and it leaves inconsistent since is not above the correct emoji anymore.

To Reproduce Steps to reproduce the behavior:

  1. Open the EmojiPicker with params including enableSearchBar and categoryPosition="bottom"
  2. Long tap to see the skin of one of the emojis
  3. Swipe to the right to the next category
  4. See that the skin selector modal still appears in the new category

Expected behavior When I swipe to a different category the skin selector modal should hide since Im no longer seeing the emoji that is associated with it.

Screenshots image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context To fix this I added in the component EmojiStaticKeyboard, in the handleScroll function, I now call the clearEmojiTonesData() function to hide the skin tones modal.

mateki0 commented 1 year ago

Hey, as for the other bug report we really appreciate your report. Maybe in the future you will open a PR with a fix? It's always nice to have a contribution to an OpenSource :)

jakex7 commented 1 year ago

Hi @ManuViola77, thanks for reporting this issue. @mateki0's fix has been merged and released in version 1.3.0.

I'm closing this issue as solved, but If it's still valid, feel free to reopen 😃