TheWidlarzGroup / rn-emoji-keyboard

Super performant, lightweight, fully customizable emoji picker 🚀
https://thewidlarzgroup.github.io/rn-emoji-keyboard/
MIT License
323 stars 55 forks source link

[1.6.1] wrong scrollNav contentOffset on iPhone 15 Pro Max #169

Closed efstathiosntonas closed 5 months ago

efstathiosntonas commented 5 months ago

Describe the bug scrollNav offset is not calculated properly on iPhone 15 pro max, when changing categories the icons background is not centered.

To Reproduce Steps to reproduce the behavior:

  1. Run demo on iphone 13 and iphone 15 pro max emulators
  2. while on iphone 13 the contentOffset is correct, on iPhone 15 pro max is not calculated properly

Expected behavior

Screenshots left iPhone 13, right iPhone 15 pro max

https://github.com/TheWidlarzGroup/rn-emoji-keyboard/assets/717975/da870554-7e70-4948-b0ca-49450c8e9c2f

Smartphone (please complete the following information):

efstathiosntonas commented 5 months ago

cc: @AnMiZa since you've opened a PR that "touches" the offesets, maybe you could take a look into it.

efstathiosntonas commented 5 months ago

nevermind, I was using react-native-size-matters in the scrollNav elements styles and this breaks the layout. After removing it everything went back to normal.

AnMiZa commented 5 months ago

@efstathiosntonas haha, that was quick 💨. I was just writing You a reply that I will take a look into it. Great that everything works fine. Have a great day 👋

efstathiosntonas commented 5 months ago

yeah, react-native-size-matters can be weird in large screens so that was my first goto to to check 😄

combined with offsets it can get bad really fast