Expand Height on Search Focus

TheWidlarzGroup / rn-emoji-keyboard

Super performant, lightweight, fully customizable emoji picker 🚀

https://thewidlarzgroup.github.io/rn-emoji-keyboard/

MIT License

330 stars 61 forks source link

Expand Height on Search Focus #44

Closed arunim2405 closed 2 years ago

arunim2405 commented 2 years ago

A quick fix that works and fixes https://github.com/TheWidlarzGroup/rn-emoji-keyboard/issues/43 Can be updated to follow project standards before merging :)

arunim2405 commented 2 years ago

Looks smoother than this, idk why it lagged in recording https://user-images.githubusercontent.com/47343112/140613361-fb40eb74-4ac1-455d-a1eb-68c141770958.mp4

jakex7 commented 2 years ago

Hi! Thank you for your contribution, however please follow CONTRIBUTING.md and update your code according to this document (prettier and eslint rules)

jakex7 commented 2 years ago

Hi @arunim2405 Is this PR is still in progress? From what i can see it's not compiling and have a lot of errors. Please let us know if you still want to progress it.

arunim2405 commented 2 years ago

@jakex7 can I please know what are the errors you're getting? Also it would be super helpful if you can leave review comments on the code which needs to be reformatted. I just modified the src of the package in the node_modules of my project and copied similar changes in this pr. Any help would be appreciated.

jakex7 commented 2 years ago

Mainly issues was:

No TypeScript and no types
Using non-existing variables (I think that's the mistake while copying files like you said)
Eslint and prettier warnings

Every of the above is listed in our community guidelines that i highly encourage to read. However, thanks to your approach, we have manage to resolve this issue as soon as possible in #47