search

TheWilley / Text2Book

A web app to convert text to Minecraft books
https://thewilley.github.io/Text2Book/
MIT License
8 stars 1 forks source link

Changed From 100 Pages per Book to 50 #12

Closed PargonX closed 8 months ago

PargonX commented 8 months ago

The default limit in Minecraft for pages in a book is 50, and bedrock users cannot read the pages after the 50th page, they just come in blank

PargonX commented 8 months ago

also changed page line limit from 14 to 13 to prevent some words overflowing and not appearing

TheWilley commented 8 months ago

I think adding a toggle to switch between a bedrock and java mode would be the better option, as that way we don't have to arbitrarily reduce the limit to 50 pages instead of 100.

Regrading the cutoff of words, its been an issue for a long time, although I've tried to solve it trough many patches. Changing the line limit to 13 will indeed solve the problem, as it creates an additional fallback line in case generation is not working as intended, but we also loose 50 / 100 lines of content. However, having words disappear is arguably worse than loosing some lines, so here's what I'm thinking:

Also, thanks for bringing this to my attention, as I totally had forgot about bedrock mode as I've only ever played on java. Good catch!

PargonX commented 8 months ago

Another thing but I don't really know typescript so your code is all over the place for me lol, but you should make a option for sending the commands directly over rcon as generated or a secondary plugin that accepts and runs the commands or something like that

On Sat, Mar 16, 2024, 3:06 AM William Larsson @.***> wrote:

I think adding a toggle to switch between a bedrock and java mode would be the better option, as that way we don't have to arbitrarily reduce the limit to 50 pages instead of 100.

Regrading the cutoff of words, its been an issue for a long time, although I've tried to solve it trough many patches. Changing the line limit to 13 will indeed solve the problem, as it creates an additional fallback line in case generation is not working as intended, but we also loose 50 / 100 lines of content. However, having words disappear is arguably worse than loosing some lines, so here's what I'm thinking:

  • The lines will be reduced to 13 until a proper fix for word cutoff is implemented.
  • A mode for bedrock will be created
  • I will close this pull request, but open an issue regarding the bedrock mode, and implement the 13 line limit in a separate commit ASAP

Also, thanks for bringing this to my attention, as I totally had forgot about bedrock mode as I've only ever played on java. Good catch!

— Reply to this email directly, view it on GitHub https://github.com/TheWilley/Text2Book/pull/12#issuecomment-2001883133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7UAT4RJEHIU5TKQNFU7TDYYPVO7AVCNFSM6AAAAABEV35PYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBRHA4DGMJTGM . You are receiving this because you modified the open/close state.Message ID: @.***>